Improve logging performance by using functions
Improve logging performance by using functions to delay when complex strings are created until after the current logging level has been checked to ensure that log statement is actually going to be printed. There are many places where very complex objects are printed at lower logging levels which this avoids.
This commit is contained in:
@@ -36,7 +36,7 @@ module.exports = class BaseController extends Backbone.View
|
||||
return child
|
||||
|
||||
refresh: ->
|
||||
logger.verbose "#{this} refreshing"
|
||||
logger.verbose => "#{this} refreshing"
|
||||
|
||||
routeLinkClick: (event)->
|
||||
href = $(event.currentTarget).attr 'href'
|
||||
@@ -91,10 +91,10 @@ module.exports = class BaseController extends Backbone.View
|
||||
data = (@model?.toHash? and @model.toHash()) or @model or {}
|
||||
|
||||
if not @_template?
|
||||
logger.error "Default render called for #{@constructor.name} without a template"
|
||||
logger.error => "Default render called for #{@constructor.name} without a template"
|
||||
return this
|
||||
|
||||
logger.verbose "#{this} rendering with data: #{data}"
|
||||
logger.verbose => "#{this} rendering with data: #{data}"
|
||||
@onWillRender()
|
||||
$oldEl = @$el
|
||||
$newEl = Backbone.$(@_template(data))
|
||||
|
||||
Reference in New Issue
Block a user