craftingguide/website
1
0
Fork 0
Code Pull Requests Actions Activity

Improve logging performance by using functions

Browse Source 
Improve logging performance by using functions to delay when complex
strings are created until after the current logging level has been
checked to ensure that log statement is actually going to be printed.
There are many places where very complex objects are printed at lower
logging levels which this avoids.
This commit is contained in:
Andrew Miner
2015-02-09 21:15:10 -08:00
parent cf6d6fdbed
commit 0a52d16eb1
8 changed files with 22 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/scripts/crafting_guide_router.coffee
+3 -3
View File
@@ -100,15 +100,15 @@ module.exports = class CraftingGuideRouter extends Backbone.Router
pathname = window.location.pathname
if global.env is 'production' and ga?
logger.info "Recording GA page view: #{pathname}"
logger.info -> "Recording GA page view: #{pathname}"
ga 'send', 'pageview', pathname
else
logger.info "Suppressing GA page view: #{pathname}"
logger.info -> "Suppressing GA page view: #{pathname}"
_setPage: (page, controller)->
return if @_controller is controller
logger.info "changing to page controller: #{controller.constructor.name}"
logger.info -> "changing to page controller: #{controller.constructor.name}"
showDuration = Duration.normal
show = =>
@_page = page