From b79fa5a148b150139caefd3ae0378eacc75ae290 Mon Sep 17 00:00:00 2001 From: Andrew Miner Date: Sat, 4 Apr 2015 18:17:15 -0700 Subject: [PATCH] Don't add incorrect history state for external links --- src/coffee/controllers/base_controller.coffee | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/coffee/controllers/base_controller.coffee b/src/coffee/controllers/base_controller.coffee index 9f13f1392..8df78d01c 100644 --- a/src/coffee/controllers/base_controller.coffee +++ b/src/coffee/controllers/base_controller.coffee @@ -63,10 +63,11 @@ module.exports = class BaseController extends Backbone.View href = $(event.target).attr 'href' href ?= $(event.currentTarget).attr 'href' logger.info "Re-routing link to internal navigation: #{href}" + if href? and href.match /^http/ window.location.href = href - - router.navigate href, trigger:true + else + router.navigate href, trigger:true show: (args...)-> {$el, callback} = @_resolveShowHideArgs args