From bd9bb2894fe01844a1862aafae0ce3bcdc979c6a Mon Sep 17 00:00:00 2001 From: Andrew Miner Date: Mon, 2 Feb 2015 09:59:01 -0800 Subject: [PATCH] Add better page names for SEO --- src/pages/layouts/basic.jade | 2 +- src/scripts/constants.coffee | 3 +++ src/scripts/controllers/item_page_controller.coffee | 3 +++ src/scripts/controllers/mod_page_controller.coffee | 3 +++ 4 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/pages/layouts/basic.jade b/src/pages/layouts/basic.jade index 489667959..1f685b817 100644 --- a/src/pages/layouts/basic.jade +++ b/src/pages/layouts/basic.jade @@ -6,7 +6,7 @@ //- block basic-vars - - var pageTitle = 'Crafting Guide' + - var pageTitle = 'Crafting Guide for Minecraft | The Ultimate Step-by-Step Tutorial for Making Anything in Minecraft' doctype html html diff --git a/src/scripts/constants.coffee b/src/scripts/constants.coffee index 08cf9d139..1c9955b30 100644 --- a/src/scripts/constants.coffee +++ b/src/scripts/constants.coffee @@ -49,6 +49,9 @@ ModelState.loading = 'loading' ModelState.loaded = 'loaded' ModelState.failed = 'failed' +exports.Text = Text = {} +Text.title = 'Crafting Guide for Minecraft | The Ultimate Step-by-Step Tutorial for Making Anything in Minecraft' + exports.Url = Url = {} Url.itemIcon = _.template "/data/<%= modSlug %>/<%= modVersion %>/images/<%= slug %>.png" Url.item = _.template "/item/<%= slug %>" diff --git a/src/scripts/controllers/item_page_controller.coffee b/src/scripts/controllers/item_page_controller.coffee index aeadb605c..e9a648431 100644 --- a/src/scripts/controllers/item_page_controller.coffee +++ b/src/scripts/controllers/item_page_controller.coffee @@ -15,6 +15,7 @@ ItemPage = require '../models/item_page' ModPackController = require './mod_pack_controller' NameFinder = require '../models/name_finder' Storage = require '../models/storage' +{Text} = require '../constants' ######################################################################################################################## @@ -86,6 +87,8 @@ module.exports = class ItemPageController extends BaseController super refresh: -> + $('title').html Text.title + if @model.plan.includingTools @$includeToolsBox.attr 'checked', 'checked' else diff --git a/src/scripts/controllers/mod_page_controller.coffee b/src/scripts/controllers/mod_page_controller.coffee index fa43abfc9..462eba94b 100644 --- a/src/scripts/controllers/mod_page_controller.coffee +++ b/src/scripts/controllers/mod_page_controller.coffee @@ -10,6 +10,7 @@ BaseController = require './base_controller' Mod = require '../models/mod' ModPack = require '../models/mod_pack' ItemGroupController = require './item_group_controller' +{Text} = require '../constants' {Url} = require '../constants' ######################################################################################################################## @@ -55,6 +56,8 @@ module.exports = class ModPageController extends BaseController super refresh: -> + $('title').html if @model? then "#{@model.name} | #{Text.title}" else Text.title + @$name.html if @model? then @model.name else '' @$byline.html if @model? then "by #{@model.author}" else '' @$titleImage.attr 'src', (if @model? then Url.modLogoImage(modSlug:@model.slug) else '')