From d0bca0d2accae78f73e4822daf941769e4c3279a Mon Sep 17 00:00:00 2001 From: Andrew Miner Date: Thu, 2 Jun 2016 11:50:58 -0600 Subject: [PATCH] Include Twitter script after Twitter button The Twitter button would frequently fail to render properly because the script which dynamically creates the proper widget would load before the DOM element which serves as the placeholder for the widget hadn't yet been created. This change ensures that the widget script is always loaded after the placeholder has been created. --- src/client/includes/_twitter_follow.jade | 11 ----------- .../mod_ballot_line/mod_ballot_line.scss | 14 +------------- src/client/site/common/twitter/twitter.jade | 2 ++ src/client/site/index.jade | 1 - 4 files changed, 3 insertions(+), 25 deletions(-) delete mode 100644 src/client/includes/_twitter_follow.jade diff --git a/src/client/includes/_twitter_follow.jade b/src/client/includes/_twitter_follow.jade deleted file mode 100644 index 4a5180440..000000000 --- a/src/client/includes/_twitter_follow.jade +++ /dev/null @@ -1,11 +0,0 @@ -script. - ! function(d, s, id) { - var js, fjs = d.getElementsByTagName(s)[0], - p = /^http:/.test(d.location) ? 'http' : 'https'; - if (!d.getElementById(id)) { - js = d.createElement(s); - js.id = id; - js.src = p + '://platform.twitter.com/widgets.js'; - fjs.parentNode.insertBefore(js, fjs); - } - }(document, 'script', 'twitter-wjs'); diff --git a/src/client/site/browse_page/mod_ballot/mod_ballot_line/mod_ballot_line.scss b/src/client/site/browse_page/mod_ballot/mod_ballot_line/mod_ballot_line.scss index 50b97f635..e686260ea 100644 --- a/src/client/site/browse_page/mod_ballot/mod_ballot_line/mod_ballot_line.scss +++ b/src/client/site/browse_page/mod_ballot/mod_ballot_line/mod_ballot_line.scss @@ -54,21 +54,9 @@ @include screen-size(mobile) { .view__mod_ballot_line { - .vote-count { - } - - & > img { - } - .name { overflow: hidden; font-size: $font-size-medium; } - - .button { - } - - .wait { - } } -} \ No newline at end of file +} diff --git a/src/client/site/common/twitter/twitter.jade b/src/client/site/common/twitter/twitter.jade index ad0517e28..ed8ac48db 100644 --- a/src/client/site/common/twitter/twitter.jade +++ b/src/client/site/common/twitter/twitter.jade @@ -16,3 +16,5 @@ data-show-count="false" data-size="large" ) Follow @Crafting_Guide + + script(id="twitter-wjs" src="//platform.twitter.com/widgets.js") diff --git a/src/client/site/index.jade b/src/client/site/index.jade index 5e332e243..0ee4711ea 100644 --- a/src/client/site/index.jade +++ b/src/client/site/index.jade @@ -33,5 +33,4 @@ html include ../includes/_google_adsense.jade include ../includes/_google_sitelinks.jade - include ../includes/_twitter_follow.jade