craftingguide/website
1
0
Fork 0
Code Pull Requests Actions Activity

Improve perf. by not showing/hiding waiting

Browse Source
This commit is contained in:
Andrew Miner
2015-11-10 21:04:20 -08:00
parent 81f1d5efc5
commit d12a318dfa
2 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/coffee/controllers/base_controller.coffee
+3 -2
View File
@@ -72,8 +72,9 @@ module.exports = class BaseController extends backbone.View
show: ($el)-> show: ($el)->
$el ?= @$el $el ?= @$el
$el.data 'target-visibility', 'visible' if $el.hasClass('hiding') or $el.hasClass('hidden')
_.delay (=> @_adjustTargetVisibility $el), Duration.snap $el.data 'target-visibility', 'visible'
_.delay (=> @_adjustTargetVisibility $el), Duration.snap
unrender: -> unrender: ->
@undelegateEvents() @undelegateEvents()
src/coffee/controllers/craftsman_working_controller.coffee
+2 -4
View File
@@ -37,7 +37,7 @@ module.exports = class CraftsmanWorkingController extends BaseController
_refreshStatusText: -> _refreshStatusText: ->
return unless @$message? and @$count? return unless @$message? and @$count?
waitingVisible = true @show @$waiting
switch @model.stage switch @model.stage
when Craftsman::STAGE.WAITING when Craftsman::STAGE.WAITING
@$message.html 'Preparing crafting calculation...' @$message.html 'Preparing crafting calculation...'
@@ -57,6 +57,4 @@ module.exports = class CraftsmanWorkingController extends BaseController
when Craftsman::STAGE.INVALID when Craftsman::STAGE.INVALID
@$message.html 'Couldn\'t make a crafting plan' @$message.html 'Couldn\'t make a crafting plan'
@$count.html '' @$count.html ''
waitingVisible = false @hide @waiting
if waitingVisible then @show @$waiting else @hide @$waiting