craftingguide/website
1
0
Fork 0
Code Pull Requests Actions Activity

Update Adsense to place ads on all devices

Browse Source 
The current adsense implementation only places ads on desktop-sized
screens.  This change allows ads of the appropriate size to be
displayed on any device.

fixes #224
This commit is contained in:
Andrew Miner
2016-05-03 20:25:56 -07:00
parent fd5372b35d
commit ebf3443e96
22 changed files with 236 additions and 125 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/client/styles/classes.scss
+1 -8
View File
@@ -74,14 +74,7 @@
}
.page > .content {
min-height: $size-skyscraper-height;
}
.skyscraper {
height : $size-skyscraper-height - 2px;
width : $size-skyscraper-width - 2px;
border : 1px solid $color-gray-medium;
min-height: $size-ad-skyscraper-height;
}
.scrollDisabled {
src/client/styles/mixins.scss
+23 -19
View File
@@ -27,54 +27,58 @@
display: flex;
& > .left {
flex: 0 0 $size-skyscraper-width + $size-margin-medium;
padding-right: $size-margin-medium;
flex : 0 0 $size-ad-skyscraper-width + $size-margin-medium;
min-height : $size-ad-skyscraper-height;
padding-right : $size-margin-medium;
@include screen-size(tablet) {
display: none;
display : none;
}
@include screen-size(mobile) {
display: none;
display : none;
}
}
& > .right {
flex: 1 1 auto;
flex : 1 1 100%;
@include screen-size(tablet) {
margin: 0 $size-margin-xlarge;
margin : 0 $size-margin-xlarge;
max-width: calc(100% - 2 * 48px); // 2 * $size-margin-xlarge
}
@include screen-size(mobile) {
margin: 0;
margin : 0;
max-width: 100%;
}
section {
margin-bottom: $size-margin-large;
margin-bottom : $size-margin-large;
}
}
}
@mixin layout-link-list {
display: flex;
flex-direction: column;
justify-content: center;
display : flex;
flex-direction : column;
justify-content : center;
p {
margin-bottom: $size-margin-small;
margin-bottom : $size-margin-small;
font-family: $font-family-text;
font-size: $font-size-large;
font-family : $font-family-text;
font-size : $font-size-large;
}
a {
margin-left: $size-margin-medium;
margin-left : $size-margin-medium;
font-family: $font-family-text;
font-size: $font-size-medium;
text-decoration: underline;
font-family : $font-family-text;
font-size : $font-size-medium;
text-decoration : underline;
&:not(:last-child) {
margin-bottom: $size-margin-medium;
margin-bottom : $size-margin-medium;
}
}
}
src/client/styles/sizes.scss
+6 -2
View File
@@ -25,5 +25,9 @@ $size-minecraft-block : 32px;
$size-page-width : $size-rem * 80;
$size-skyscraper-height : 600px;
$size-skyscraper-width : 160px;
$size-ad-large-mobile-banner-height : 100px;
$size-ad-large-mobile-banner-width : 320px;
$size-ad-leaderboard-height : 90px;
$size-ad-leaderboard-width : 728px;
$size-ad-skyscraper-height : 600px;
$size-ad-skyscraper-width : 160px;