Qualify all item slugs to the mod which adds them #53
* Change default item URL to fall under /mod/<mod slug>/<item slug> but kept the old URL pattern around with the old behavior (i.e., find the first item with that slug) * Update Item to have a `qualifiedSlug` property which combines the item's own slug with its Mod's slug. Updated a lot of code all over to use this in preference to the plain slug. * Add a `localizeTo` method to Inventory to allow non-qualified slugs to be converted into qualified slugs within the inventory's stacks * Update ModPack to work with either qualified or unqualified slugs for relevant methods * Fix model state changes to happen before related events are triggered * Add a debounce to the CraftingPlan object when triggering a recraft due to changes in related objects (esp. its inventories) * Update the Inventory's sort to keep items sorted by mod before name with the Minecraft items sorted to the top * Fix `ModPack.findItemByName` to actually recursively use the Mod's method instead of slugifying the given name and looking for the slug (since this won't necessarily work anymore). * Ensure each Mod is assigned a reference to its containing ModPack * Fix NameFinder to only consider an item non-gatherable if it is also craftable * Update ModVersionParserV1 to assign qualified slugs to recipes for any items which are in the same mod (leaving any other slugs unqualified) * Add Underscore mixins for composing and decomposing slugs * Update old tests for the use of qualified slugs, and some new tests for the new methods added
This commit is contained in:
@@ -15,8 +15,7 @@ module.exports = class Recipe extends BaseModel
|
||||
constructor: (attributes={}, options={})->
|
||||
if attributes.item?
|
||||
attributes.name = attributes.item.name
|
||||
attributes.slug = attributes.item.slug
|
||||
attributes.output ?= [new Stack slug:attributes.item.slug, quantity:1]
|
||||
attributes.output ?= [new Stack slug:attributes.item.qualifiedSlug, quantity:1]
|
||||
|
||||
if not attributes.name? then throw new Error 'attributes.name is required'
|
||||
if not attributes.input? then throw new Error 'attributes.input is required'
|
||||
@@ -25,11 +24,13 @@ module.exports = class Recipe extends BaseModel
|
||||
attributes.item ?= null
|
||||
attributes.output ?= [new Stack slug:_.slugify(attributes.name), quantity:1]
|
||||
attributes.pattern = @_parsePattern attributes.pattern
|
||||
attributes.slug ?= attributes.output[0].slug
|
||||
attributes.tools ?= []
|
||||
options.logEvents ?= false
|
||||
super attributes, options
|
||||
|
||||
Object.defineProperties this,
|
||||
slug: {get:@getSlug}
|
||||
|
||||
# Public Methods ###############################################################################
|
||||
|
||||
getItemSlugAt: (patternSlot)->
|
||||
@@ -48,6 +49,12 @@ module.exports = class Recipe extends BaseModel
|
||||
return true if stack.slug is itemSlug
|
||||
return false
|
||||
|
||||
# Property Methods #############################################################################
|
||||
|
||||
getSlug: ->
|
||||
return @item.qualifiedSlug if @item?
|
||||
return @output[0].slug
|
||||
|
||||
# Object Overrides #############################################################################
|
||||
|
||||
toString: ->
|
||||
|
||||
Reference in New Issue
Block a user