Andrew Miner
380a78ef61
* Change default item URL to fall under /mod/<mod slug>/<item slug> but kept the old URL pattern around with the old behavior (i.e., find the first item with that slug) * Update Item to have a `qualifiedSlug` property which combines the item's own slug with its Mod's slug. Updated a lot of code all over to use this in preference to the plain slug. * Add a `localizeTo` method to Inventory to allow non-qualified slugs to be converted into qualified slugs within the inventory's stacks * Update ModPack to work with either qualified or unqualified slugs for relevant methods * Fix model state changes to happen before related events are triggered * Add a debounce to the CraftingPlan object when triggering a recraft due to changes in related objects (esp. its inventories) * Update the Inventory's sort to keep items sorted by mod before name with the Minecraft items sorted to the top * Fix `ModPack.findItemByName` to actually recursively use the Mod's method instead of slugifying the given name and looking for the slug (since this won't necessarily work anymore). * Ensure each Mod is assigned a reference to its containing ModPack * Fix NameFinder to only consider an item non-gatherable if it is also craftable * Update ModVersionParserV1 to assign qualified slugs to recipes for any items which are in the same mod (leaving any other slugs unqualified) * Add Underscore mixins for composing and decomposing slugs * Update old tests for the use of qualified slugs, and some new tests for the new methods added
183 lines
6.4 KiB
CoffeeScript
183 lines
6.4 KiB
CoffeeScript
###
|
|
# Crafting Guide - inventory.test.coffee
|
|
#
|
|
# Copyright (c) 2014-2015 by Redwood Labs
|
|
# All rights reserved.
|
|
###
|
|
|
|
{Event} = require '../src/scripts/constants'
|
|
EventRecorder = require './event_recorder'
|
|
Inventory = require '../src/scripts/models/inventory'
|
|
Item = require '../src/scripts/models/item'
|
|
|
|
########################################################################################################################
|
|
|
|
inventory = modPack = null
|
|
|
|
########################################################################################################################
|
|
|
|
describe 'inventory.coffee', ->
|
|
|
|
beforeEach ->
|
|
inventory = new Inventory {}, silent:false
|
|
inventory.add 'wool', 4
|
|
inventory.add 'string', 20
|
|
inventory.add 'boat'
|
|
|
|
describe 'add', ->
|
|
|
|
it 'can add to an empty inventory', ->
|
|
inventory.add 'iron_ingot', 4
|
|
stack = inventory._stacks['iron_ingot']
|
|
stack.constructor.name.should.equal 'Stack'
|
|
stack.slug.should.equal 'iron_ingot'
|
|
stack.quantity.should.equal 4
|
|
|
|
it 'can augment quantity of existing items', ->
|
|
inventory.add 'wool', 2
|
|
inventory.toList().should.eql ['boat', [20, 'string'], [6, 'wool']]
|
|
|
|
it 'can add zero quantity', ->
|
|
inventory.add 'wool', 0
|
|
inventory.toList().should.eql ['boat', [20, 'string'], [4, 'wool']]
|
|
|
|
it 'emits the proper events', ->
|
|
events = new EventRecorder inventory
|
|
inventory.add 'iron_ingot', 10
|
|
events.names.should.eql [Event.add, Event.change]
|
|
|
|
describe 'addInventory', ->
|
|
|
|
it 'can add to an empty inventory', ->
|
|
newInventory = new Inventory
|
|
newInventory.addInventory inventory
|
|
newInventory._slugs.should.eql ['boat', 'string', 'wool']
|
|
|
|
it 'can add a mix of new and existing items', ->
|
|
newInventory = new Inventory
|
|
newInventory.add 'string', 2
|
|
newInventory.addInventory inventory
|
|
newInventory.toList().should.eql ['boat', [22, 'string'], [4, 'wool']]
|
|
|
|
describe 'clone', ->
|
|
|
|
it 'creates an empty inventory from an empty inventory', ->
|
|
a = new Inventory
|
|
b = a.clone()
|
|
b._slugs.should.eql []
|
|
|
|
it 'faithfully copies an existing inventory', ->
|
|
copy = inventory.clone()
|
|
copy.toList().should.eql ['boat', [20, 'string'], [4, 'wool']]
|
|
|
|
describe 'each', ->
|
|
|
|
it 'works with an empty inventory', ->
|
|
inventory = new Inventory
|
|
result = []
|
|
inventory.each (item)-> result.push item.name
|
|
result.should.eql []
|
|
|
|
it 'works when items have only been added', ->
|
|
result = []
|
|
inventory.each (stack)-> result.push stack.slug
|
|
result.should.eql ['boat', 'string', 'wool']
|
|
|
|
it 'works when items have been augmented', ->
|
|
inventory.add 'iron_ingot'
|
|
inventory.add 'boat'
|
|
inventory.add 'wool', 2
|
|
|
|
result = []
|
|
inventory.each (stack)-> result.push stack.slug
|
|
result.should.eql ['boat', 'iron_ingot', 'string', 'wool']
|
|
|
|
describe 'hasAtLeast', ->
|
|
|
|
it 'works when the item is completely absent', ->
|
|
answer = inventory.hasAtLeast 'chicken', 1
|
|
answer.should.be.false
|
|
|
|
it 'always returns true for zero quantity', ->
|
|
inventory.hasAtLeast('chicken', 0).should.be.true
|
|
inventory.hasAtLeast('wool', 0).should.be.true
|
|
|
|
it 'works for a quantity above 1', ->
|
|
inventory.hasAtLeast('wool', 3).should.be.true
|
|
inventory.hasAtLeast('wool', 4).should.be.true
|
|
inventory.hasAtLeast('wool', 5).should.be.false
|
|
|
|
describe 'localizeTo', ->
|
|
|
|
before ->
|
|
modPack =
|
|
map:
|
|
wool: 'minecraft__wool'
|
|
string: 'minecraft__string'
|
|
boat: 'minecraft__boat'
|
|
stone_gear: 'buildcraft__stone_gear'
|
|
findItem: (slug)->
|
|
[modSlug, itemSlug] = _.decomposeSlug slug
|
|
return slug:itemSlug, qualifiedSlug:@map[itemSlug]
|
|
|
|
it 'replaces item slugs with qualified slugs', ->
|
|
inventory.add 'stone_gear'
|
|
inventory.localizeTo modPack
|
|
inventory.toList().should.eql [
|
|
'minecraft__boat',
|
|
[20, 'minecraft__string'],
|
|
[4, 'minecraft__wool'],
|
|
'buildcraft__stone_gear'
|
|
]
|
|
|
|
it 'ignores qualified slugs', ->
|
|
inventory.add 'buildcraft__stone_gear'
|
|
inventory.localizeTo modPack
|
|
inventory.toList().should.eql [
|
|
'minecraft__boat',
|
|
[20, 'minecraft__string'],
|
|
[4, 'minecraft__wool'],
|
|
'buildcraft__stone_gear'
|
|
]
|
|
|
|
describe 'pop', ->
|
|
|
|
it 'returns null for an empty inventory', ->
|
|
inventory = new Inventory
|
|
result = inventory.pop()
|
|
expect(result).to.be.null
|
|
|
|
it 'completely removes the last item', ->
|
|
stack = inventory.pop()
|
|
stack.slug.should.equal 'wool'
|
|
stack.quantity.should.equal 4
|
|
inventory.toList().should.eql ['boat', [20, 'string']]
|
|
|
|
it 'triggers the right events', ->
|
|
events = new EventRecorder inventory
|
|
result = inventory.pop()
|
|
events.names.should.eql [Event.remove, Event.change]
|
|
|
|
describe 'remove', ->
|
|
|
|
it 'throws when the item is absent', ->
|
|
expect(-> inventory.remove('chicken')).to.throw Error,
|
|
'cannot remove chicken since it is not in this inventory'
|
|
|
|
it 'throws when the item has insufficient quantity', ->
|
|
expect(-> inventory.remove('wool', 10)).to.throw Error,
|
|
'cannot remove 10: only 4 wool in this inventory'
|
|
|
|
it 'removes all items by default', ->
|
|
inventory.remove 'wool'
|
|
expect(inventory._stacks.wool).to.be.empty
|
|
|
|
it 'removes a quantity above 1', ->
|
|
inventory.remove 'wool', 3
|
|
inventory._stacks.wool.quantity.should.equal 1
|
|
|
|
it 'emits the proper events', ->
|
|
events = new EventRecorder inventory
|
|
inventory.remove 'wool'
|
|
events.names.should.eql [Event.remove, Event.change]
|